Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modern theme #861

Merged
merged 71 commits into from
Nov 21, 2023
Merged

Modern theme #861

merged 71 commits into from
Nov 21, 2023

Conversation

nojaf
Copy link
Collaborator

@nojaf nojaf commented Nov 3, 2023

Update the default theme to use more modern web standards.
This cannot be merged until it is completed.
Alpha previews will be released from this branch.
This PR serves as a more convenient way to track the changes.

@nojaf nojaf marked this pull request as draft November 3, 2023 07:49
@@ -119,26 +119,26 @@
--link-color: #c5eff7;
--search-background: #020202;
--nav-category: rgb(207, 211, 215);
--code-strings-color: #5adfec;
--code-strings-color: #86b4b9;
--code-printf-color: #6B2FBA;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--code-printf-color: #6B2FBA;
--code-printf-color: #e786f4;

--code-activepattern-color: #4ec9b0;
--code-unioncase-color: #4ec9b0;
--code-enumeration-color: #8C6C41;
--code-keywords-color: #a7c2f8;
--code-comment-color: #dcd8d8;
--code-comment-color: #84d16e;
--code-operators-color: #b4c6ee;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--code-operators-color: #b4c6ee;
--code-operators-color: #00d8ff;

--code-activepattern-color: #4ec9b0;
--code-unioncase-color: #4ec9b0;
--code-enumeration-color: #8C6C41;
--code-keywords-color: #a7c2f8;
--code-comment-color: #dcd8d8;
--code-comment-color: #84d16e;
--code-operators-color: #b4c6ee;
--code-numbers-color: #009999;
--code-linenumbers-color: #80b0b0;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--code-mutable-color: ffb000;

@kMutagene kMutagene mentioned this pull request Nov 18, 2023
@nojaf nojaf marked this pull request as ready for review November 20, 2023 07:52
@nojaf
Copy link
Collaborator Author

nojaf commented Nov 20, 2023

Hi @kMutagene and @nhirschey,

It might be more convenient if we merge this into the main branch.
I would like to have:

as part of v20, as they are great additions.

I would keep everything in alpha still, so we can revisit anything we want.
Sounds good?

@nojaf
Copy link
Collaborator Author

nojaf commented Nov 21, 2023

Alright, I'm calling it a day.
We can continue to work on this on the main branch if something still needs a tweak.

@nojaf nojaf merged commit dca47e4 into main Nov 21, 2023
2 checks passed
@nojaf nojaf deleted the modern-theme branch November 21, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modernize the default theme
3 participants